Skip to content

Add the 2factor dialog after login #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2024
Merged

Conversation

gjong
Copy link
Contributor

@gjong gjong commented May 23, 2024

Proposed change

In case the user has activated they will no longer be allowed to access the main application.
Instead, they will be redirected to a form to enter a verification code.
Only after this has succeeded will they be redirected to the main application.

This change is required after the backend change, as the backend now enforces the 2factor to be used or it will deny with 403 on all resources.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the application)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

@gjong gjong added the enhancement New feature or request label May 23, 2024
@gjong gjong self-assigned this May 23, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gjong gjong merged commit 7fe860b into master May 23, 2024
5 checks passed
@gjong gjong deleted the feature/add-2factor-dialog branch May 23, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the 2-factor authentication screen back in
1 participant